Skip to content

docs: slim CLAUDE.md in favor of global agent-tools skills#98

Open
alex-mextner wants to merge 1 commit into
mainfrom
docs/slim-agents-global-skills
Open

docs: slim CLAUDE.md in favor of global agent-tools skills#98
alex-mextner wants to merge 1 commit into
mainfrom
docs/slim-agents-global-skills

Conversation

@alex-mextner

Copy link
Copy Markdown
Owner

Slims the project guide by replacing portable dev-discipline sections with one-line pointers to the now-public skills at github.com/alex-mextner/agent-tools, while keeping every ExpenseSyncBot-specific rule.

Removed → referenced as skills

  • Foundational Rules → smallest-change, yagni-kiss-dry, systematic-debugging
  • Writing Code (generic) → smallest-change, comment-hygiene, dependency-version-ranges, no-type-escape-hatches, unused-params, no-silent-fallbacks, fail-closed-security, atomic-db-transactions
  • Naming & Code Comments → naming, comment-hygiene, file-header-comments
  • Systematic Debugging → systematic-debugging
  • Generic TDD/test discipline → tdd-red-first, test-discipline
  • Version-control basics → atomic-commits, pre-commit-gate, ai-review-before-commit, push-regularly, deferred-findings-tracking, worktree-isolation
  • Session Wrap-Up → task-completion-selfcheck (also drops the Cyrillic, satisfying English-only repo docs)

Kept (project-specific)

Architecture, file paths, commands, deploy, the bun test-runner / :memory: / mock.module plumbing, pino logger conventions, biome/lefthook config, the knip+codex commit gate, Telegram callback_data (fitCallbackData) guidance, bot identity/tone, ZenPlugins workflow.

Net: 41 insertions / 62 deletions, one file.

🤖 Generated with Claude Code

Replace portable dev-discipline sections (foundational rules, naming,
comment hygiene, systematic debugging, generic TDD/test discipline,
version-control basics, session self-check) with one-line pointers to
the now-public skills at github.com/alex-mextner/agent-tools. Keep every
ExpenseSyncBot-specific rule: architecture, file paths, commands, deploy,
the bun test-runner/:memory:/mock.module plumbing, the knip+codex commit
gate, and the project callback_data guidance. Also removes Cyrillic from
the Session Wrap-Up section (now a skill pointer), satisfying the
English-only repo-docs rule.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🤖 Stage bot deployed! Test it: https://t.me/ExpenseSyncStageBot

Branch: docs/slim-agents-global-skills @ 294d4a6

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42fee3bf5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CLAUDE.md
- **Deferred findings**: when skipping a review finding (out of scope, pre-existing), create a GitHub
issue for it. Don't silently drop known issues.
> Portable: global skills `atomic-commits`, `pre-commit-gate`, `ai-review-before-commit`,
> `push-regularly`, `deferred-findings-tracking`, `worktree-isolation`. (No blind `git add -A`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point at the actual worktree skill

The referenced replacement skill does not exist in github.com/alex-mextner/agent-tools/skills/universal; the available worktree-related skill is worktree-base-trap, while this new pointer says worktree-isolation. Because the old inline worktree workflow was removed in this commit, agents following this guide in a worktree session will fail to load the intended rule and lose the protection against pushing directly to main or touching the main checkout.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant